Merge pull request #83 from haacked/haacked/checkbox-remote-validatio…

…n-fix Checkbox remote validation fix
haacked · Dec 12, 2023 · 637efeb · 637efeb
2 parents 3e40223 + 6bb07bd
commit 637efeb
Show file tree

Hide file tree

Showing 9 changed files with 28 additions and 9 deletions.
diff --git a/Controllers/Validations.cs b/Controllers/Validations.cs
@@ -10,6 +10,12 @@ public IActionResult CheckRemote(string id)
         return Ok(id == "42");
     }
 
+    [HttpPost]
+    public IActionResult CheckboxRemote(bool isChecked)
+    {
+        return Ok(isChecked);
+    }
+
     [HttpGet]
     public IActionResult Test()
     {

diff --git a/Pages/Demos/Checkboxes.cshtml b/Pages/Demos/Checkboxes.cshtml
@@ -52,8 +52,8 @@
                 <label>@animal</label>
             }
             <span asp-validation-for="SelectedAnimals"></span>
-            @if (Model.SelectedAnimals.Any()) {
-                <em class="results">Selected animals: @string.Join(", ", Model.SelectedAnimals)</em>
+            @if (Model.SelectedAnimals!.Any()) {
+                <em class="results">Selected animals: @string.Join(", ", Model.SelectedAnimals!)</em>
             }
         </div>
 

diff --git a/Pages/Demos/Checkboxes.cshtml.cs b/Pages/Demos/Checkboxes.cshtml.cs
@@ -41,6 +41,7 @@ public IActionResult OnPost()
 
     public class InputModel
     {
+        [Remote("CheckboxRemote", "Validations", HttpMethod = "Post")]
         public bool IsChecked { get; set; }
     }
 
@@ -50,6 +51,7 @@ public class InputModel
     public class Selectable
     {
         public required string Name { get; set; }
+
         public bool IsSelected { get; set; }
     }
 }
diff --git a/dist/aspnet-validation.js b/dist/aspnet-validation.js
@@ -396,7 +396,13 @@ var MvcValidationProviders = /** @class */ (function () {
                 if (!hasValue) {
                     continue;
                 }
-                fields[fieldName] = fieldElement.value;
+                if (fieldElement instanceof HTMLInputElement &&
+                    (fieldElement.type === 'checkbox' || fieldElement.type === 'radio')) {
+                    fields[fieldName] = fieldElement.checked ? fieldElement.value : '';
+                }
+                else {
+                    fields[fieldName] = fieldElement.value;
+                }
             }
             var url = params['url'];
             var encodedParams = [];

diff --git a/dist/aspnet-validation.min.js b/dist/aspnet-validation.min.js
diff --git a/dist/aspnet-validation.min.js.map b/dist/aspnet-validation.min.js.map
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "aspnet-client-validation",
-  "version": "0.9.2",
+  "version": "0.9.3",
   "description": "Enables ASP.NET MVC client-side validation, without jQuery!",
   "main": "dist/aspnet-validation.js",
   "style": "dist/aspnet-validation.css",

diff --git a/src/index.ts b/src/index.ts
@@ -351,7 +351,12 @@ export class MvcValidationProviders {
                 continue;
             }
 
-            fields[fieldName] = fieldElement.value;
+            if (fieldElement instanceof HTMLInputElement &&
+                (fieldElement.type === 'checkbox' || fieldElement.type === 'radio')) {
+                fields[fieldName] = fieldElement.checked ? fieldElement.value : '';
+            } else {
+                fields[fieldName] = fieldElement.value;
+            }
         }
 
         let url: string = params['url'];