-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for HTTP/3 #331
base: main
Are you sure you want to change the base?
Conversation
Regarding >1 vhosts on the same Nginx instance, I'm using the config from this PR on multiple vhosts and it fails at the Is it possible (or viable) to spin up a second vhost instance in this repo to see if that triggers the error on CI, given the experimental implementation of HTTP/3 in Nginx 1.25.0? |
Thanks for your comment @petecooper.
That is definitely possible. This config is still at its very early stage, only tested with my custom build so far. I guess for now the best option is to segregate h3 port from other protocols.
Possible, always, but not realistic: this would imply importing the whole Nginx build workflow, which is way too far out of the scope. |
If anyone is interested, I once wrote this script to compile NGINX with H3 support, maybe it will help testing/debugging: https://gist.github.com/muuvmuuv/73b9008a393fd1b2c45d202ea11b6487 And, I don't have the issue with "duplicate listen". www-server.confserver {
listen 443 http3 reuseport;
listen 443 http2 ssl;
root /etc/nginx/www;
server_name localhost;
index index.html;
include /etc/nginx/h5bp/h5bp/tls/ssl_engine.conf;
include /etc/nginx/custom.d/certificate_files.conf;
include /etc/nginx/custom.d/ssl_policy.conf;
include /etc/nginx/h5bp/h5bp/security/referrer-policy.conf;
include /etc/nginx/h5bp/h5bp/security/x-content-type-options.conf;
include /etc/nginx/h5bp/h5bp/security/x-frame-options.conf;
include /etc/nginx/h5bp/h5bp/security/content-security-policy.conf;
include /etc/nginx/h5bp/h5bp/security/strict-transport-security.conf;
include /etc/nginx/h5bp/h5bp/security/permissions-policy.conf;
include /etc/nginx/h5bp/h5bp/location/security_file_access.conf;
location / {
add_header Access-Control-Expose-Headers '*';
add_header Access-Control-Allow-Origin '*';
add_header Access-Control-Allow-Credentials 'true';
add_header Access-Control-Allow-Methods '*';
add_header Access-Control-Allow-Headers '*';
add_header Alt-Svc 'h3=":$server_port"; ma=86400';
add_header X-Protocol $server_protocol always;
try_files $uri $uri/ 404=;
}
include /etc/nginx/policies/*.conf;
} |
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Pete Cooper <[email protected]> Co-authored-by: Léo Colombaro <[email protected]>
Initial configuration, based on https://nginx.org/en/docs/http/ngx_http_v3_module.html.
See also: https://nginx.org/en/docs/http/ngx_http_core_module.html#listen
http{}
level)