Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SAS token renewal #203

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Add SAS token renewal #203

merged 2 commits into from
Sep 10, 2024

Conversation

KaSroka
Copy link
Contributor

@KaSroka KaSroka commented Sep 10, 2024

No description provided.

@KaSroka KaSroka force-pushed the add_sas_token_renewal branch 2 times, most recently from 774e1e0 to 3cbd078 Compare September 10, 2024 08:05
@tux1980
Copy link

tux1980 commented Sep 10, 2024

Thanks! But is not yet in the main branch, is it? Because HACS is not offering any updates to the Toshiba Integration right now.
Screenshot from 2024-09-10 10-34-42

@KaSroka
Copy link
Contributor Author

KaSroka commented Sep 10, 2024

It's not merged so not available.

@tux1980
Copy link

tux1980 commented Sep 10, 2024

Are you going to merge it (different people had this issue I mean) or am I supposed to change my code in my HA manual? But next update will come and my added changes will be most likely overwritten afterwards.

@KaSroka
Copy link
Contributor Author

KaSroka commented Sep 10, 2024

It seems like you don't know how GitHub works, let me explain - @h4de5 is the owner of this repo and the only person with permissions to merge this (as of now).

@tux1980
Copy link

tux1980 commented Sep 10, 2024

Sorry I thought you have the permissions to merge this repos. Ok, then I wait for an answer from @h4de5
And no, I'm a bit familiar, I've been using GitHub for years now:)

@h4de5 h4de5 merged commit 88eae54 into h4de5:main Sep 10, 2024
3 checks passed
@h4de5
Copy link
Owner

h4de5 commented Sep 10, 2024

merged, release and tested.

@KaSroka thanks, great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants