Open
Conversation
mturoci
requested changes
Apr 8, 2025
Collaborator
mturoci
left a comment
mturoci
left a comment
There was a problem hiding this comment.
Thanks @sulhicader please do not forget to include a demo showing the Tour working properly.
| description: "Skip publishing docs site" | ||
| required: false | ||
| default: "false" | ||
| push: |
Collaborator
There was a problem hiding this comment.
Do not forget to revert this file once done.
| @@ -0,0 +1,41 @@ | |||
| FROM cgr.dev/chainguard/wolfi-base:latest@sha256:91ed94ec4e72368a9b5113f2ffb1d8e783a91db489011a89d9fad3e3816a75ba | |||
Collaborator
There was a problem hiding this comment.
Would be better to name it *.dockerfile to get proper syntax highlighting etc.
| USER root | ||
| RUN python3 -m pip uninstall pip -y | ||
| RUN mkdir -p /resources | ||
| RUN chmod -R 777 /resources |
Collaborator
There was a problem hiding this comment.
777 doesn't seem like a proper permission here - not secure. Can you elaborate on why it's needed?
py/apps/tour/requirements.txt
Outdated
| bokeh==2.4.2 | ||
| Faker==13.3.4 | ||
| h2o-wave-ml==0.8.1 | ||
| h2o-wave[ml]==1.6.3 |
Collaborator
There was a problem hiding this comment.
This duplicates h2o-wave package, why is the change needed?
Contributor
Author
There was a problem hiding this comment.
This change came from other PR. I replied in PR2454.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR fulfills these requirements: (check all the apply)
mainbranch.feat: Add a button #xxx, where "xxx" is the issue number).Closes #xxx, where "xxx" is the issue number.uifolder, unit tests (make test) still pass.Closes #2455