fix: Raise error if waved cannot find public/private dir #2130#2213
Open
92ammarraza wants to merge 6 commits intoh2oai:mainfrom
Open
fix: Raise error if waved cannot find public/private dir #2130#221392ammarraza wants to merge 6 commits intoh2oai:mainfrom
92ammarraza wants to merge 6 commits intoh2oai:mainfrom
Conversation
mturoci
requested changes
Dec 7, 2023
Collaborator
mturoci
left a comment
There was a problem hiding this comment.
Thanks @92ammarraza! A small refactor needed and should be good to go.
Collaborator
|
Hey @92ammarraza. Make sure the comments are addressed in the correct branch. File changes view doesn't show your latest changes. |
Author
|
Hey @mturoci , Me and @johnmrzo are working together in team on this for a class. He has pushed the latest changes. Looking forward to your feedback. |
mturoci
requested changes
Dec 11, 2023
Collaborator
mturoci
left a comment
There was a problem hiding this comment.
Please make sure you test your code and it works correctly. It does not at the moment. An err is thrown even for valid directories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR fulfills these requirements: (check all the apply)
mainbranch.feat: Add a button #xxx, where "xxx" is the issue number).Closes #xxx, where "xxx" is the issue number.uifolder, unit tests (make test) still pass.Related issue #2130
Overview:
This pull request addresses the issue #2130 , where waved would start without error even if the specified public/private directories were missing or incorrectly configured. The changes introduce error checking during server startup to ensure these directories exist and are accessible.
Changes:
checkDirectoryfunction inserver.goto validate the existence of public and private directories.Testing
Closes #2130