Conversation
|
Thanks for the PR @7460m! Did you manually verify all the examples work as before and their behavior was not changed after your refactors? |
py/examples/graphics_spline.py
Outdated
| g.spline(x=[float(v) for v in x], y=[float(v) for v in y], curve='linear', style=line_style), | ||
| g.spline(x=[float(v) for v in x], y=[float(v) for v in y], curve='basis', style=line_style), | ||
| g.spline(x=[float(v) for v in x], y=[float(v) for v in y], curve='basis-closed', style=line_style), |
There was a problem hiding this comment.
This makes code harder to follow. Is there any other way to make mypy happy while preserving the original way of passing params to spline?
There was a problem hiding this comment.
Updated with a function to make it clear, I've try to modify x outside of the list and it seems not working
There was a problem hiding this comment.
also I've manually checked before and after, the line seems thinner because of the **line_style -> style=line_style. let me know whats you thoughts on fixing this
py/examples/image.py
Outdated
| c=[(0.90687198, 0.0, 0.0), (0.78837333, 0.0, 0.0), (0.76840584, 0.0, 0.0), (0.59849648, 0.0, 0.0), (0.44214562, 0.0, 0.0), (0.72303802, 0.0, 0.0), | ||
| (0.41661825, 0.0, 0.0), (0.2268104, 0.0, 0.0), (0.45422734, 0.0, 0.0), (0.84794375, 0.0, 0.0), (0.93665595, 0.0, 0.0), (0.95603618, 0.0, 0.0), | ||
| (0.39209432, 0.0, 0.0), (0.70832467, 0.0, 0.0), (0.12951583, 0.0, 0.0), (0.35379639, 0.0, 0.0), (0.40427152, 0.0, 0.0), (0.6485339, 0.0, 0.0), | ||
| (0.03307097, 0.0, 0.0), (0.53800936, 0.0, 0.0), (0.13171312, 0.0, 0.0), (0.52093493, 0.0, 0.0), (0.10248479, 0.0, 0.0), (0.15798038, 0.0, 0.0), | ||
| (0.92002965, 0.0, 0.0)], |
There was a problem hiding this comment.
image.py:29: error: List item 1 has incompatible type "float"; expected "tuple[float, float, float] | str | tuple[float, float, float, float] | tuple[tuple[float, float, float] | str, float] | tuple[tuple[float, float, float, float], float]" [list-item]
There was a problem hiding this comment.
I'll work on it to see if there's another way, its currently all red dots..
There was a problem hiding this comment.
I've looked into this one, in the plt.scatter document said "A scalar or sequence of n numbers to be mapped to colors using cmap and norm." which I think the original code is perfectly fine, but mypy doesn't think so, ill put ignore on it for now, if you want me to put in random value to satisfy the mypy let me know.
| str_cols = df.select_dtypes(include=['object']).columns | ||
| return df[df[str_cols].apply(lambda column: column.str.contains(term, case=False, na=False)).any(axis=1)] |
There was a problem hiding this comment.
What mypy err does this resolve?
There was a problem hiding this comment.
table_filter_backend.py:31: error: List item 0 has incompatible type "type[object]"; expected "str" [list-item]
|
Hi mturoci, Thanks for the review, I"ll work on it and get back to you asap |
2 participants
The PR fulfills these requirements: (check all the apply)
Fixed: #2047
mainbranch.feat: Add a button #xxx, where "xxx" is the issue number).Closes #xxx, where "xxx" is the issue number.uifolder, unit tests (make test) still pass.Mypy result before:
Fixed:Found 218 errors in 23 files (checked 273 source files)
Mypy result after:
Success: no issues found in 273 source files