Fix error with stdout and stderr together in shell command when running git_date update#3480
Open
frederikdyrmose wants to merge 2 commits intoh2oai:mainfrom
Open
Fix error with stdout and stderr together in shell command when running git_date update#3480frederikdyrmose wants to merge 2 commits intoh2oai:mainfrom
frederikdyrmose wants to merge 2 commits intoh2oai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling from source on aarch64 I encounter an error regarding converting git_date to UTC time due to the inclusion of stderr in stdout:
This error is fixed by not mixing stdout and stderr in the shell_cmd function. I updated the function, and now it compiles without any problems on linux aarch64, linux x86_64 and windows x86_64 when testing locally.