Generate payload for multiple datagrams at once #609
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now,
on_send_emitcallback has been invoked for each STREAM frame being built. This has become a bottleneck, due to two reasons:preadfor each call toon_send_emit.To mitigate the issuse, this PR refactors the
quicly_send_streamfunction to generate STREAM frames for as much as 10 packets at once.This PR calls the
on_send_emitcallback that already exists, and scatters the data being read by callingmemmove.There are two alternatives that we might consider:
readv) that match to the payload section of multiple STREAM frames being generated.It might turn out that we'd want to try these alternatives, but they require changes to the API. Therefore, as the first cut, we are trying the approach using
memmove.