[DO NOT MERGE YET] add options for testing retransmission behavior #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazuho
changed the base branch from
master
to
kazuho/never-trim-stream-frames
kazuho
changed the title
kazuho
commented
Dec 5, 2021
Member
Author
kazuho
left a comment
kazuho
left a comment
There was a problem hiding this comment.
FWIW, I'm confident with fragment_payload, but am uncertain if we need to have destroy_packet inside lib/quicly.c.
The latter can instead be implemented inside the code that uses quicly (e.g., quicly/cli, h2o), by discarding datagrams probablistically.
kazuho
changed the base branch from
kazuho/never-trim-stream-frames
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two fields to
quicly_context_tas well as command line options for controlling them incli.fragment_payload- cause fragmentation of stream data being sentdestroy_packet- ratio at which packets being sent should be destroyed (so that they would be rejected by the receiver)These options can be together used as a way of testing retransmission behavior regardless of type of the payload (assuming that the message being transmitted is longer than one byte).
Note: for reproducible behavior, use of x25519 as key exchange is recommended (
-x x25519), because the encoded size of secp256r1 public key can change by one byte.Builds on top of #497.