[sentmap] split packet-level and frame-level structure #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improves the interation speed at the cost of memory footprint. Iteration speed becomes an issue when ACKs with many gaps are registered, as one ack range occupies one element of the frame-level structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing so improves the iteration speed at the cost of memory footprint.
At the moment, for sentmap, we use a linked-list of blocks, that consists with either packet-level information or frame-level information. Therefore, the cost of iterating through the sentmap becomes a cost, if there are excessive number of frame-level entries being associated to each packet-level information. #487 tries to solve the problem by reducing the number of frame-level entries.
This PR tries to solve the problem by splitting the packet-level and frame-level structure. Frame-level information is stored as part of the packet-level structure when the number of frame-level entries is below 4. If not, they are allocated using
malloc.