Fix CLI params parser

.github/workflows/test.yml

@@ -45,19 +45,10 @@ jobs:
       run: filetype --help
 
     - name: Install test framework dependencies
-      run: python -m pip install pytest pytest-random-order pytest-cov pytest-html
-
-    - name: UnitTest with pytest and coverage
-      run: |
-        pytest \
-            --random-order \
-            --random-order-bucket=global \
-            --ignore=examples \
-            --ignore=tests/test_benchmark.py \
-            --cov=filetype \
-            --cov-report html:coverage/ \
-            tests \
-            ;
+      run: python -m pip install tox
+
+    - name: Run tox pipeline
+      run: tox
 
     - name: HTML coverage reports
       if: always()

filetype/__main__.py

@@ -1,3 +1,5 @@
+import sys
+
 import filetype
 
 
@@ -12,17 +14,23 @@ def guess(path):
 def main():
     import argparse
 
-    parser = argparse.ArgumentParser(description='Determine type of FILEs.')
-    parser.add_argument("file", nargs='+')
-    parser.add_argument('-v', '--version', action='store_true',
-                        help='output version information and exit')
+    parser = argparse.ArgumentParser(
+        prog='filetype', description='Determine type of FILEs.'
+    )
+    parser.add_argument('-f', '--file', nargs='+')
+    parser.add_argument(
+        '-v', '--version', action='version',
+        version='%(prog)s ' + filetype.version,
+        help='output version information and exit'
+    )
+
     args = parser.parse_args()
+    if len(sys.argv) < 2:
+        parser.print_help()
+        sys.exit(1)
 
-    if args.version:
-        print(filetype.version)
-    else:
-        for i in args.file:
-            guess(i)
+    for i in args.file:
+        guess(i)
 
 
 if __name__ == '__main__':

filetype/types/image.py

@@ -196,7 +196,7 @@ def match(self, buf):
                     buf[2] == 0x2A and buf[3] == 0x0) or
                 (buf[0] == 0x4D and buf[1] == 0x4D and
                     buf[2] == 0x0 and buf[3] == 0x2A))
-                and not(buf[8] == 0x43 and buf[9] == 0x52))
+                and not (buf[8] == 0x43 and buf[9] == 0x52))
 
 
 class Bmp(Type):

filetype/utils.py

@@ -1,6 +1,5 @@
 # -*- coding: utf-8 -*-
 
-from io import BufferedIOBase
 # Python 2.7 workaround
 try:
     import pathlib
@@ -73,14 +72,13 @@ def get_bytes(obj):
     if isinstance(obj, pathlib.PurePath):
         return get_signature_bytes(obj)
 
-    if isinstance(obj, BufferedIOBase):
-        start_pos = obj.tell()
-        obj.seek(0)
-        magic_bytes = obj.read(_NUM_SIGNATURE_BYTES)
-        obj.seek(start_pos)  # restore reader position
-        return get_bytes(magic_bytes)
-
     if hasattr(obj, 'read'):
+        if hasattr(obj, 'tell') and hasattr(obj, 'seek'):
+            start_pos = obj.tell()
+            obj.seek(0)
+            magic_bytes = obj.read(_NUM_SIGNATURE_BYTES)
+            obj.seek(start_pos)
+            return get_bytes(magic_bytes)
         return get_bytes(obj.read(_NUM_SIGNATURE_BYTES))
 
     raise TypeError('Unsupported type as file input: %s' % type(obj))

tox.ini

@@ -4,18 +4,29 @@
 # and then run "tox" from this directory.
 
 [tox]
-envlist = py{27,35,36,37,38,39}, lint, doc, clean
+envlist = py{27,35,36,37,38,39}, lint, test, doc, clean
 skip_missing_interpreters = true
 
 [testenv:test]
-deps = pytest
-commands = pytest --ignore=tests/test_benchmark.py
+deps =
+     pytest
+     pytest-random-order
+     pytest-cov
+     pytest-html
+commands = pytest \
+           --random-order \
+           --random-order-bucket=global \
+           --ignore=examples \
+           --ignore=tests/test_benchmark.py \
+           --cov=filetype \
+           --cov-report html:coverage/ \
+           tests
 
 [testenv:lint]
 basepython = python3
 deps =
      flake8
-commands = flake8 {toxinidir} --extend-exclude tests,docs,build,dist,venv
+commands = flake8 {toxinidir} --extend-exclude tests,docs,build,dist,venv --extend-ignore=E501
 
 [testenv:doc]
 basepython = python3