Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tensor improvements #171

Merged
merged 3 commits into from
Mar 7, 2025
Merged

Tensor improvements #171

merged 3 commits into from
Mar 7, 2025

Conversation

EmilyBourne
Copy link
Member

Add the missing static_assert in tensor_mul which verifies the validity of the tensor multiplication. Add missing consts in tensor.hpp

@EmilyBourne EmilyBourne marked this pull request as ready for review March 7, 2025 09:29
@EmilyBourne EmilyBourne requested a review from yanmnc March 7, 2025 09:29
@EmilyBourne EmilyBourne temporarily deployed to GitLab GPU trigger March 7, 2025 09:30 — with GitHub Actions Inactive
@EmilyBourne EmilyBourne added the Ready to merge Label to be automatically added to a PR when it is approved and tests are passing label Mar 7, 2025
@EmilyBourne EmilyBourne enabled auto-merge (squash) March 7, 2025 09:55
@tpadioleau
Copy link
Member

Do we really want the bitwise operator &= ? I think we expect the logical AND operator for booleans.

@EmilyBourne EmilyBourne disabled auto-merge March 7, 2025 09:55
@EmilyBourne
Copy link
Member Author

Do we really want the bitwise operator &= ? I think we expect the logical AND operator for booleans.

Are they not equivalent for booleans?

@tpadioleau
Copy link
Member

tpadioleau commented Mar 7, 2025 •
edited
Loading

Do we really want the bitwise operator &= ? I think we expect the logical AND operator for booleans.

Are they not equivalent for booleans?

I think they are, but do you want to allow a & b for booleans ?

Edit: they don't seem to produce the exact same assembly without optimisations, see this godbolt example

@EmilyBourne EmilyBourne temporarily deployed to GitLab GPU trigger March 7, 2025 10:25 — with GitHub Actions Inactive
@EmilyBourne EmilyBourne merged commit 9f3278a into main Mar 7, 2025
18 checks passed
@EmilyBourne EmilyBourne deleted the ebourne_tensor_improvements branch March 7, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpadioleau tpadioleau tpadioleau approved these changes

@yanmnc yanmnc yanmnc approved these changes

Assignees
No one assigned
Labels
Ready to merge Label to be automatically added to a PR when it is approved and tests are passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EmilyBourne @tpadioleau @yanmnc