Skip to content

Update minimal version support of DDC #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2025
Merged

Update minimal version support of DDC #155

merged 2 commits into from
Mar 5, 2025

Conversation

tpadioleau
Copy link
Member

@tpadioleau tpadioleau commented Mar 3, 2025 •
edited
Loading

  • set minimum supported to version 0.5.1, this brings the new DDC domains
  • isolate the maxwellian tests to avoid failures, not clear yet why this makes it work. The issue is being tracked by Segfault from tests CExA-project/ddc#790

@tpadioleau tpadioleau self-assigned this Mar 3, 2025
@tpadioleau tpadioleau marked this pull request as ready for review March 3, 2025 18:10
@tpadioleau tpadioleau temporarily deployed to GitLab GPU trigger March 3, 2025 18:10 — with GitHub Actions Inactive
@EmilyBourne EmilyBourne marked this pull request as draft March 4, 2025 13:59
@tpadioleau tpadioleau mentioned this pull request Mar 4, 2025
Closed
@tpadioleau tpadioleau marked this pull request as ready for review March 4, 2025 17:14
@tpadioleau tpadioleau temporarily deployed to GitLab GPU trigger March 4, 2025 17:15 — with GitHub Actions Inactive
@tpadioleau tpadioleau temporarily deployed to GitLab GPU trigger March 4, 2025 20:02 — with GitHub Actions Inactive
@tpadioleau tpadioleau added the Ready to review Label to be automatically added to a PR when it is ready to be reviewed label Mar 5, 2025
EmilyBourne
EmilyBourne reviewed Mar 5, 2025
View reviewed changes
@EmilyBourne EmilyBourne added Ready to merge Label to be automatically added to a PR when it is approved and tests are passing and removed Ready to review Label to be automatically added to a PR when it is ready to be reviewed labels Mar 5, 2025
@EmilyBourne EmilyBourne merged commit 91cc28d into main Mar 5, 2025
20 checks passed
@EmilyBourne EmilyBourne deleted the update-ddc branch March 5, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilyBourne EmilyBourne EmilyBourne approved these changes

Assignees

@tpadioleau tpadioleau

Labels
Ready to merge Label to be automatically added to a PR when it is approved and tests are passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpadioleau @EmilyBourne