Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adastra toolchain's prepare.sh #154

Merged
merged 8 commits into from
Mar 5, 2025
Merged

Conversation

etiennemlb
Copy link
Collaborator

  • Fixes an issue with ginkgo not being built using the appropriate architecture.
  • Prevent sourcing.
  • Update to ginkgo 1.9
  • Avoid hardcoding ${SPACK_USER_PREFIX}/config_user_spack

# Conflicts:
#	toolchains/mi250.hipcc.adastra.spack/prepare.sh
Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me. I think we should wait for the results with @AbdelhadiKara before merging.

Was your branch up to date with main ? I don't understand why the static analysis failed.

@etiennemlb etiennemlb had a problem deploying to GitLab GPU trigger March 4, 2025 08:32 — with GitHub Actions Failure
@EmilyBourne
Copy link
Member

Does this PR close #151?

Copy link

github-actions bot commented Mar 4, 2025

This PR is failing tests so it has been put back into draft. Please remove the draft status when the tests pass.

@github-actions github-actions bot marked this pull request as draft March 4, 2025 08:42
@AbdelhadiKara
Copy link
Collaborator

A first Installation/compilation attempt led to fix the matrix_tools tests on device.
OpenMp must nevertheless be deactivated.

@AbdelhadiKara
Copy link
Collaborator

It will be necessary to revert my commit.
And replace generic by mi250 [ in environment.sh file ] (

gcc/13.2.1.generic/zen3/libyaml \
)

@AbdelhadiKara AbdelhadiKara added the bug Something isn't working label Mar 4, 2025
@etiennemlb etiennemlb force-pushed the feature/upate_prepare branch from 14bc781 to 4f3852f Compare March 4, 2025 15:29
@etiennemlb etiennemlb marked this pull request as ready for review March 5, 2025 09:07
@etiennemlb etiennemlb temporarily deployed to GitLab GPU trigger March 5, 2025 10:03 — with GitHub Actions Inactive
@EmilyBourne EmilyBourne linked an issue Mar 5, 2025 that may be closed by this pull request
@EmilyBourne EmilyBourne added the Ready to review Label to be automatically added to a PR when it is ready to be reviewed label Mar 5, 2025
Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me, @AbdelhadiKara can you confirm this is the file you used to do your tests ?

Copy link
Collaborator

@AbdelhadiKara AbdelhadiKara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After compiling and running the ginkgo-related tests on the amd gpu, it was working for me yesterday. There are still two other points to be clarified, not in the scope of this MR.
The first concerns the fact that having device and Openmp activated at the same time breaks certain tests in matrix_utils.
The second concerns the extension of the polar poisson test timeout.

@tpadioleau
Copy link
Member

After compiling and running the ginkgo-related tests on the amd gpu, it was working for me yesterday. There are still two other points to be clarified, not in the scope of this MR. The first concerns the fact that having device and Openmp activated at the same time breaks certain tests in matrix_utils. The second concerns the extension of the polar poisson test timeout.

Ok thanks, can you open issues about this if they don't already exist ?

@EmilyBourne EmilyBourne added Ready to merge Label to be automatically added to a PR when it is approved and tests are passing and removed Ready to review Label to be automatically added to a PR when it is ready to be reviewed labels Mar 5, 2025
@EmilyBourne
Copy link
Member

After compiling and running the ginkgo-related tests on the amd gpu, it was working for me yesterday. There are still two other points to be clarified, not in the scope of this MR. The first concerns the fact that having device and Openmp activated at the same time breaks certain tests in matrix_utils. The second concerns the extension of the polar poisson test timeout.

Ok thanks, can you open issues about this if they don't already exist ?

@AbdelhadiKara Can you take care of this. I will merge once this is done

@AbdelhadiKara
Copy link
Collaborator

Issues created :
Extend timeout
OpenMp issue

@EmilyBourne EmilyBourne merged commit 3e3d48d into main Mar 5, 2025
33 of 34 checks passed
@EmilyBourne EmilyBourne deleted the feature/upate_prepare branch March 5, 2025 15:56
@etiennemlb
Copy link
Collaborator Author

etiennemlb commented Mar 5, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Ready to merge Label to be automatically added to a PR when it is approved and tests are passing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protect scripts that should not be sourced
4 participants