-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update adastra toolchain's prepare.sh #154
Conversation
# Conflicts: # toolchains/mi250.hipcc.adastra.spack/prepare.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me. I think we should wait for the results with @AbdelhadiKara before merging.
Was your branch up to date with main ? I don't understand why the static analysis failed.
Does this PR close #151? |
This PR is failing tests so it has been put back into draft. Please remove the draft status when the tests pass. |
A first Installation/compilation attempt led to fix the matrix_tools tests on device. |
It will be necessary to revert my commit.
|
14bc781
to
4f3852f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me, @AbdelhadiKara can you confirm this is the file you used to do your tests ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After compiling and running the ginkgo-related tests on the amd gpu, it was working for me yesterday. There are still two other points to be clarified, not in the scope of this MR.
The first concerns the fact that having device and Openmp activated at the same time breaks certain tests in matrix_utils.
The second concerns the extension of the polar poisson test timeout.
Ok thanks, can you open issues about this if they don't already exist ? |
@AbdelhadiKara Can you take care of this. I will merge once this is done |
Issues created : |
the config given by cines has an "off by one" issue in the yaml syntax (the Inès config is slightly old). not an issue but spack does not like that when we want to change the config via the cli.
…On 5 March 2025 14:11:12 UTC, Thomas Padioleau ***@***.***> wrote:
@tpadioleau commented on this pull request.
Ok for me, @AbdelhadiKara can you confirm this is the file you used to do your tests ?
> "
# ***@***.******@***.***~bignuma~consistent_fpcsr+dynamic_dispatch+fortran~ilp64+locking+pic+shared build_system=makefile symbol_suffix=none threads=none arch=linux-rhel8-zen3
which spack
+spack config --scope user update --yes-to-all packages
What does this line do exactly ? What config does it update, with respect to what ?
|
${SPACK_USER_PREFIX}/config_user_spack