Upgrade Node runtime from node16 to node24 (PF-3311)#5
Merged
Conversation
The action manifest still declared runs.using: 'node16', so the action ran on the deprecated Node 16 runtime. The earlier 'chore: update to node 20' commit (2878fc9) only touched build/CI/linter config and never changed the using: field, so the action kept running on node16. Change runs.using to 'node24' and regenerate dist/ with @vercel/ncc.
fhp
marked this pull request as ready for review
June 25, 2026 10:08
fhp
removed their request for review
June 29, 2026 19:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This action was running on the deprecated Node 16 runtime. This PR moves it to the Node 24 runtime.
Before / After
action.ymldeclaredruns.using: 'node16', so GitHub executed the action on the deprecated Node 16 runtime.runs.using: 'node24'— the action now runs on Node 24.How
runs.usinginaction.ymlfromnode16tonode24.chore: update to node 20commit (2878fc9, 2024-11-25) only touched build/CI/linter config — it never changed the manifest'susing:field, so the action kept running on node16 in production. This PR fixes that.dist/with@vercel/ncc(the bundle is effectively unchanged — a couple of bytes from a refreshed transitive dependency tree; the manifest change is the substantive part).The bundle built cleanly on a Node 24-capable toolchain, so node24 was kept (no fallback to node20 was needed).
Follow-up (post-merge)
After this merges, the
v1tag should be re-pointed to the merge commit (or a new tag cut) so downstream consumers actually pick up the node24 runtime. For examplegynzy/lib-jsonnetpinsgynzy/wait-for-http-content@v1; until the tag is moved it will keep resolving to the old node16 build.Reference
Linear: PF-3311