Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return_tiles argument #431

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from
Draft

Add return_tiles argument #431

wants to merge 4 commits into from

Conversation

rubencalje
Copy link
Collaborator

No description provided.

@martinvonk martinvonk linked an issue Mar 19, 2025 that may be closed by this pull request
@rubencalje
Copy link
Collaborator Author

So a lot of changes, @martinvonk . Can you explain what the purpose of these changes is? And I think we should use type hints everywhere in NLmod, or no type hints at all (which I like more).

@martinvonk
Copy link
Collaborator

I tried to add some code to use the old _download_and_combine_tiles function to merge the separate tiles. This function used a memoryfile thingy, and the merge function instead of merge_arrays which might be a solution to #429.

And yes, I added some type hints 👼. Originally because I was confused about the expected input for some functions. Later more, because I thought it is nice to be explicit in the function call which specific version (strings) need to be provided for an AHN request. Btw, there are already some type hints in NLmod. I'm always in favor of more documentation instead of less.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merging AHN tiles takes forever
2 participants