Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanilla universe #169

Merged
merged 13 commits into from
Mar 19, 2024
Merged

Vanilla universe #169

merged 13 commits into from
Mar 19, 2024

Conversation

areeda
Copy link
Contributor

@areeda areeda commented Mar 19, 2024

Add a command line `--no-submit option which can be combined with --omega-scans option to create the omega batch DAG submit file.

This is needed when hveto is run in the vanilla universe because the [sub]DAG cannot be submitted from an EP.

The weekly run will create a DAG to deal with this. 3 time daily runs will do the same eventually but will continue to work in the local universe.

The real work will be in the ligo-monitors project .

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 40.52%. Comparing base (80e7279) to head (475a544).

Files Patch % Lines
hveto/__main__.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
+ Coverage   40.51%   40.52%   +0.01%     
==========================================
  Files          22       22              
  Lines        1755     1757       +2     
==========================================
+ Hits          711      712       +1     
- Misses       1044     1045       +1     
Flag Coverage Δ
Conda 40.52% <50.00%> (+0.01%) ⬆️
Linux 40.52% <50.00%> (+0.01%) ⬆️
macOS 40.52% <50.00%> (+0.01%) ⬆️
python3.10 40.52% <50.00%> (+0.01%) ⬆️
python3.11 40.52% <50.00%> (+0.01%) ⬆️
python3.9 40.55% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hveto/__main__.py Outdated Show resolved Hide resolved
hveto/__main__.py Outdated Show resolved Hide resolved
@areeda
Copy link
Contributor Author

areeda commented Mar 19, 2024

Thanks Duncan, suggestions implemented so I'm merging

@areeda areeda merged commit e972226 into gwdetchar:master Mar 19, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants