Add #ifdef guards around UI_GET_SYSNAME#218
Merged
sezanzeb merged 1 commit intogvalkov:mainfrom Apr 28, 2024
Merged
Conversation
If the C code is built with a kernel header that does not provide UI_GET_SYSNAME, then ui_get_sysname() will always raise OSError. (Unless incorrect arguments are provided to the function, in which case the function still behaves as it otherwise would.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python code is already ready to deal with
uinput_get_sysname()throwing OSError in case the ioctlUI_GET_SYSNAMEis not available, but it turns out that the C object code refuses to link if the macroUI_GET_SYSNAMEwas not defined at build time, because the compiler assumes thatUI_GET_SYSNAMEis a symbol that will be defined later at link time. (Issue #178)Add an
#ifdefguard around the code that relies onUI_GET_SYSNAMEso that no reference to any hypothetical symbolUI_GET_SYSNAMEremains in the object code if theUI_GET_SYSNAMEmacro was undefined at build time. This will causeuinput_get_sysname()to raise OSError if theUI_GET_SYSNAMEwas not defined at build time.