Bsg mul add unsigned dev #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sys-log-filepath flag
…d main.rkt in order to separate it from the other PR
…d into bsg_mul_add_unsigned_dev
Changing solver back to Bitwuzla
testing cvc5 solver - stp didnt work so far - bitwuzla didnt work so far
adjusted params
testing yices
gussmith23
requested changes
Aug 5, 2024
bin/main.rkt
Outdated
There was a problem hiding this comment.
Unnecessary change, please remove
There was a problem hiding this comment.
I would add this to your private .git/info/exclude, not here!
There was a problem hiding this comment.
If you don't explicitly exclude this file, lit will try to run it like a test, which is part of why you're getting errors in CI:
...
Unresolved Tests (3):
Lakeroad tests :: bsg_defines.sv
Lakeroad tests :: bsg_dff.sv
Lakeroad tests :: bsg_dff_chain.sv
...
Can you do two things:
- Put the files into a folder called
bsg_mul_add_unsigned - Exclude the files so that
litdoesn't try to run them
You can see an example here:
https://github.com/uwsampl/lakeroad/pull/447/files#
There was a problem hiding this comment.
Please delete this whole folder, I think it was checked in accidentally!
lakeroad-private
Outdated
gussmith23
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New (separate) PR to add the BaseJump STL mul-add-unsigned file into Lakeroad