-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for D inputs on DSP #255
Conversation
I nearly lost this PR! Currently working on finally merging this so that @vcanumalla can use it in eval. |
See #288. This is a hack around that. This will quickly be overwritten, i'm sure, though. Next time I reimport these semantics, I'm sure I'll forget to change this back.
Why wasn't this a constant in the first place?
This was seemingly blowing up synthesis
SummaryAfter merging in the existing changes on main, I started having some problems with solver scaling on this PR. I spent a lot of time figuring it out; in the end, it ended up being a matter of just narrowing down the search space by restricting the concrete and symbolic variables. We need to spend some time (ideally with a solver expert) in figuring out which solver to use, and what flags to use with it! |
Extends DSP primitive interface to support another input, D
Adds integration test for a module which Vivado (Vivado v2021.2 (64-bit), SW Build 3367213 on Tue Oct 19 02:47:39 MDT 2021, IP Build 3369179 on Thu Oct 21 08:25:16 MDT 2021) fails
Adds a script for Verilator testing
Fix hardcoded path in integration test; add environment variable for
lakeroad-private
and check that it is setFix Verilator portability issues