Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support editor to return PromiseLike object #48

Merged
merged 1 commit into from
Dec 17, 2023

Conversation

superfreeeee
Copy link
Contributor

Enable editor to return Promise object which contains new JSON object as its value

@superfreeeee
Copy link
Contributor Author

@rejas hello there, can you please checkout this pull request for me, I really need this feature in my own project

@rejas
Copy link
Collaborator

rejas commented Dec 12, 2023

@superfreeeee Unfortunately I dont have aproject anymore where I use this. So you have to tell me please: is this a breaking change or do existing projects have to adjust if I merge this?

@superfreeeee
Copy link
Contributor Author

superfreeeee commented Dec 16, 2023

@superfreeeee Unfortunately I dont have aproject anymore where I use this. So you have to tell me please: is this a breaking change or do existing projects have to adjust if I merge this?

@rejas There is no breaking change, but enable developers to return PromiseLike object and fit into node Readable stream created by gulp.
After this update, those who already use this plugin won't need to change there code, but they can change editor function to async if they need it. Please check it out.

@rejas rejas merged commit f4244f7 into gulp-community:main Dec 17, 2023
3 checks passed
@rejas
Copy link
Collaborator

rejas commented Dec 17, 2023

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants