reset _sqlsafe when scanning multiple documents; added tests
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oalders
added a commit
to perl-ide/Perl-Critic-Policy-ValuesAndExpressions-PreventSQLInjection
that referenced
this pull request
Mar 4, 2021
- Added test for heredoc terminators
guillaumeaubert#17
(Victor Efimov)
- Reset `_sqlsafe` when scanning multiple documents; added tests
guillaumeaubert#22
(Charlie Garrison)
- New test cases related to anonymous functions
guillaumeaubert#18
(Victor Efimov)
- Add safe_context configuration option
guillaumeaubert#23
(Nelson Ferraz)
- Added a new "prefer_upper_case_keywords" configuration option (Olaf Alders)
- Added detection for ALTER, CREATE and DROP statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting false positives for violations marked as safe, when scanning multiple documents.
I have overridden the
prepare_to_scan_documentmethod fromPerl::Critic::Policyto reset the_sqlsafeattribute. Resetting the attribute for each document fixes the problem.I also added some tests. Running the test against the current version will fail. The tests pass with the changes in this PR.