-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add completion and instruct engines for GoogleAI #822
base: main
Are you sure you want to change the base?
Conversation
Hi @x3haloed, we're actually thinking about moving in the opposite direction and reducing the overall class surface exposed to users by removing You can see the first cut of work in that direction in my PR here: #822. The idea is that there will just be a single Would love to better understand what models you'd like supported in GoogleAI, and how I can enable them in the new direction of the codebase. I'd appreciate your thoughts on this directional change at large! |
Hi @Harsha-Nori, I think your goals with the new ChatTemplate API sound great. If you'd be willing to take this PR, I think it could plug a gap in the featureset while you finish working on the ChatTemplate implementation. I'm not sure how close you are to being able to roll that out. Either way, I really don't care whether access happens via VertexAI or Google AI Studio under the hood. Thank you for your time! |
Thanks @x3haloed ! We're hoping to merge my change in pretty soon -- next day or two. We can come back and update this PR with an example of how gemini-1.5-pro-latest can be used. |
Hi @Harsha-Nori, Looks like PR #820 was merged in and released with v0.1.15. Do you mind giving me a little update here about how to generate text completions with |
I propose merging these commits that add in the missing completion and instruct engines for GoogleAI. With these inclusions, Gemini can be more fully supported.
The one hitch with this implementation is that Google AI Studio uses the same model name for different modalities like completion vs instruct vs chat, so it's not possible to determine which to use in the generalized class definition based on the model name alone as it is with other LLM services.
Unless maintainer has a better idea, I have decided to handle this situation by implementing with GoogleAIChat by default (as it was before), allowing for users specify different modalities by constructing GoogleAICompletion or GoogleAIInstruction directly.