Skip to content

Fixes #4080. TabGroup not always navigate correctly across groups #4085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Jun 4, 2025

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented May 14, 2025

Fixes

Proposed Changes/Todos

  • Added new method MoveOverlappedSubViewToEnd
  • Fix and added 2 more unit tests

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

Sorry, something went wrong.

BDisp added 2 commits May 14, 2025 18:10

Verified

This commit was signed with the committer’s verified signature.
BDisp BDisp

Verified

This commit was signed with the committer’s verified signature.
BDisp BDisp
@BDisp BDisp requested a review from tig as a code owner May 14, 2025 17:14
BDisp and others added 7 commits May 14, 2025 22:16

Verified

This commit was signed with the committer’s verified signature.
BDisp BDisp

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
BDisp BDisp
BDisp added 8 commits May 31, 2025 23:08

Verified

This commit was signed with the committer’s verified signature.
BDisp BDisp

Verified

This commit was signed with the committer’s verified signature.
BDisp BDisp

Verified

This commit was signed with the committer’s verified signature.
BDisp BDisp

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
BDisp BDisp

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
BDisp BDisp

Verified

This commit was signed with the committer’s verified signature.
BDisp BDisp
@BDisp
Copy link
Collaborator Author

BDisp commented Jun 1, 2025

With the MoveSubViewToEnd_ViewArrangement unit test you can't see the difference and behave the same no matter is used ViewArrangement.Fixed or ViewArrangement.Overlapped. The only unit test where you can confirm that this PR really behave as expected is the Toplevel_TabGroup_Forward_Backward because the issue is only visible when a driver is really running.

Verified

This commit was signed with the committer’s verified signature.
BDisp BDisp
@BDisp
Copy link
Collaborator Author

BDisp commented Jun 1, 2025

This isn't working in release mode in the NativeAot project.

BDisp and others added 4 commits June 3, 2025 11:03

Verified

This commit was signed with the committer’s verified signature.
BDisp BDisp

Verified

This commit was signed with the committer’s verified signature.
BDisp BDisp

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
BDisp BDisp
@BDisp BDisp requested a review from tig June 4, 2025 18:03

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done.!

@tig tig merged commit 4f707c4 into gui-cs:v2_develop Jun 4, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TabGroup not always navigate correctly across groups
2 participants