Jalaali (Persian) Date input support #1205
Conversation
|
Is this something that could be done with inheritance? By making Then users could create their own custom date formats and calendars types? Could even have a Jalaali version of DateField (either in core or Scenarios) to show how to implement. |
Sounds good! It needs to change some methods identifiers in |
this seems like a good approach. |
There was a problem hiding this comment.
We currently have zero unit tests for DateField. Via other tests, it has about 53% code coverage.
I'd like to ask you to add a DateFieldTest.cs module with some tests that would get this closer to 80%. Would you please do this as part of this PR?
Examples:
- the constructors
- functions like
GetLongFormat, 'GetDate', etc... - anywhere you see any sort of logic that maniuplates stuff
Thanks!!!!
| @@ -47,9 +48,11 @@ public class DateField : TextField { | |||
| /// <param name="y">The y coordinate.</param> | |||
| /// <param name="date">Initial date contents.</param> | |||
| /// <param name="isShort">If true, shows only two digits for the year.</param> | |||
| public DateField (int x, int y, DateTime date, bool isShort = false) : base (x, y, isShort ? 10 : 12, "") | |||
| /// <param name="isJalaali">If true, parse will convert jalaali input fo georgian date</param> | |||
| public DateField (int x, int y, DateTime date, bool isShort = false, bool isJalaali = false) : base (x, y, isShort ? 10 : 12, "") | |||
There was a problem hiding this comment.
A few unit tests that prove the various constructors work as they should would be good.
| @@ -377,6 +410,28 @@ public virtual void OnDateChanged (DateTimeEventArgs<DateTime> args) | |||
| { | |||
| DateChanged?.Invoke (args); | |||
| } | |||
|
|
|||
| string ToJalaaliString (string format, DateTime date) | |||
There was a problem hiding this comment.
You should have a unit test for this.
|
Hi @inamvar - We'd love to integrate this PR. Will you have a chance soon to address the changes requested? |
|
@inamvar - are you still interested in helping with this? |
|
@inamvar - I'm marking this as a Draft PR. Hope you come back some time and help us get this merged in! |
resolving issue #1204