Banner accessibility - refactor moment template #781
Conversation
| reminderTracking, | ||
| separateArticleCount, | ||
| includeSignIn, |
There was a problem hiding this comment.
is this a new feature you're adding to the moment banner?
There was a problem hiding this comment.
Yes, but ... the more I think about it, the less I like it. We do need asignIn attribute which will include the sign-in copy and CTA line, which appears in some existing Banners, either following the body copy or following the CTA buttons.
This fix would allow us to add a dropdown to the RRCP banner variants form for Marketing to add the sign-in line (= easy A/B testing). But I'm now thinking that this is more of a design choice and we should probably set the signIn attribute in the JSON that gets fed into the Moment template. If Marketing want banner variations with/without the sign-in line then engineers can create two banners from the template and make them available in the RRCP banner dropdown.
Thoughts?
There was a problem hiding this comment.
if the moment template banner doesn't currently support the feature then I'm not sure how it relates to the accessibility task?
There was a problem hiding this comment.
Removed. Will fix when we refactor existing banners which use the sign-in link to use the Moment template
What does this change?
We need to refactor the Moment Template component to make it amenable for our planned banner accessibility fix
Screenshots (generic banner with image)
Mobile
Tablet and wider
Additional parts of the banner exposed
