Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [TEST] Trigger snyk #750

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: [TEST] Trigger snyk #750

wants to merge 2 commits into from

Conversation

jfsoul
Copy link
Contributor

@jfsoul jfsoul commented Sep 16, 2022

DO NOT MERGE - draft snyk integration. This PR tests whether or not integration with a snyk GHA will work out of the box. You can safely ignore it for now.

@jfsoul
Copy link
Contributor Author

jfsoul commented Sep 16, 2022

This project uses yarn workspaces, but it looks like there might also be npm lock files present?

@jfsoul
Copy link
Contributor Author

jfsoul commented Sep 29, 2022

Also already has a workflow...

@jfsoul
Copy link
Contributor Author

jfsoul commented Sep 29, 2022

I think commit 7c6a156 should be reverted, I was misled by an error message into thinking packages/modules/package.json was not one of the yarn workspaces. In fact, it is and there is a more accurate error message hidden away that is probably the root cause of the failure:

ERROR: OutOfSyncError: Dependency @sdc/shared was not found in yarn.lock. Your package.json and yarn.lock are probably out of sync. Please run "yarn install" and try again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jfsoul