Refactor cdk into yarn workspaces #522
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompretty
force-pushed
the
tp-cdk-workspace-refactor
branch
from
7fa9f32 to
42e6780
Compare
tompretty
commented
Sep 15, 2021
Comment on lines
-1
to
+2
| import type { Policy } from '@aws-cdk/aws-iam'; | ||
| import type { App } from '@aws-cdk/core'; | ||
| import { Policy } from '@aws-cdk/aws-iam'; | ||
| import { App } from '@aws-cdk/core'; |
There was a problem hiding this comment.
I wanted to use the top level .eslintrc for cdk too which required dropping these type imports
tompretty
force-pushed
the
tp-cdk-workspace-refactor
branch
from
42e6780 to
1e7b96c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Refactor the
cdkdirectory into a yarn workspace along side the existing ones.