Update admin to no longer aggregate on common

[akash1810]

In SBT, aggregate means:

Aggregation means that running a task on the aggregate project will also run it on the aggregated projects.

This means if a task is run on the admin project, it'll also be run on common. This isn't necessary as we only need to compile common.

What is the value of this and can you measure success?

What does this change?

Screenshots

Checklist

• Tested locally, and on CODE if necessary
• Will not break dotcom-rendering
• Any new test data/database files generated by tests are committed with this PR (the tests will fail in CI if you've forgotten to do this)
• Meets our accessibility standards
  • Tested with screen reader
  • Navigable with keyboard
  • Colour contrast passed

[github-actions]

Deploy build 3773 of dotcom:frontend-all to CODE

All deployment options

• Deploy build 3773 of dotcom:frontend-all to CODE
• Deploy parts of build 3773 to CODE by previewing it first
• What's on CODE right now?

---

From guardian/actions-riff-raff.

[adamnfish]

Be aware that this means running the tests for adin won't also run the tests for common, which is probably the behaviour people expect.

Without knowing more about the error you're solving here I can't make an alternative suggestion, but make sure you aren't missing any important behaviour after doing this!

[akash1810]

Be aware that this means running the tests for adin won't also run the tests for common, which is probably the behaviour people expect.

Is this true? Each Play app dependsOn commonWithTests, which is implemented here.

[adamnfish]

Be aware that this means running the tests for adin won't also run the tests for common, which is probably the behaviour people expect.

Is this true? Each Play app dependsOn commonWithTests, which is implemented here.

withTests adds the common module's tests as a dependency for the admin module's tests. You can read the following as saying "the admin code depends on the common code, and the admin tests depend on the common tests".

frontend/project/ProjectSettings.scala

Lines 144 to 146 in 379308c

	def withTests(project: Project): ClasspathDep[ProjectReference] =
	project % "test->test;compile->compile"
	}

Typically dependsOn only adds the actual source code as a dependency (the admin code depends on the common code), and the way to ask for the tests to also be included is not very intuitive, so this helper makes it a bit easier to dicover and read.

So the "with tests" helper is about code dependencies (dependsOn), aggregate is about task dependencies (aggregate).

Depends on is about making source code from other projects available, and aggregate is about making sure sbt commands are run across multiple projects at once.

In this case, by removing the common aggregation, you're saying that runnings admin/test won't also automatically run common/test. As well as people expecting this, it'd be good to double check that this isn't an important assumption in the CI checks etc. I think there's a good chance this change would cause test failures to get missed in the future, for example.