-
Notifications
You must be signed in to change notification settings - Fork 30
Add Product Cards #14772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Product Cards #14772
Conversation
… colours for the product cards. Add the Product Card image component. Add the correct sizing to the Picture component for the new Product Image.
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
JamieB-gu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some comments and questions.
…e instead of a div
Co-authored-by: Jamie B <[email protected]>
JamieB-gu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Couple of small comments.
Co-authored-by: Jamie B <[email protected]>
Co-authored-by: Jamie B <[email protected]>
|
Seen on PROD (merged by @oliverabrahams 8 minutes and 8 seconds ago) Please check your changes! |
What does this change?
Adds a new reusable product card components with inline and left-column variants.
Changes
Why?
This is part of the wider work introducing a new product element used in The Filter articles. It will provide a structured product data and should make it easier to build on.
Related PR: Add Product Element
Screenshots
Inline Product Card
Product Card only

With custom attributes

In dark mode 🌝

Product Card + photo credit (in dark mode 🌝)

Left Col Card
Product Card + custom attributes

In dark mode 🌝

Product Card Only (in dark mode 🌝)
