Skip to content

Conversation

@oliverabrahams
Copy link
Contributor

@oliverabrahams oliverabrahams commented Oct 29, 2025

What does this change?

Adds a new reusable product card components with inline and left-column variants.

Changes

  • Added InlineProductCard and LeftColProductCard components for displaying product details, images and buttons.
  • Created Storybook stories to showcase different states and configurations.
  • Introduced ProductCardButtons and ProductCardImage for consistent button and image handling across product cards.
  • Extended the Picture component with a new productCard role and responsive image widths.
  • Added new theme palette values for product card backgrounds, borders and buttons to support light and dark modes.

Why?

This is part of the wider work introducing a new product element used in The Filter articles. It will provide a structured product data and should make it easier to build on.

Related PR: Add Product Element

Screenshots

Inline Product Card

Product Card only
image

With custom attributes
image

In dark mode 🌝
image

Product Card + photo credit (in dark mode 🌝)
image


Left Col Card

Product Card + custom attributes
image

In dark mode 🌝
image

Product Card Only (in dark mode 🌝)
image

… colours for the product cards. Add the Product Card image component. Add the correct sizing to the Picture component for the new Product Image.
@github-actions
Copy link

github-actions bot commented Oct 30, 2025

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

@oliverabrahams oliverabrahams added the run_chromatic Runs chromatic when label is applied label Oct 30, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Oct 30, 2025
@charleycampbell charleycampbell marked this pull request as ready for review October 30, 2025 11:32
@github-actions
Copy link

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@oliverabrahams oliverabrahams requested a review from a team October 30, 2025 14:35
Copy link
Contributor

@JamieB-gu JamieB-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some comments and questions.

@oliverabrahams oliverabrahams added the run_chromatic Runs chromatic when label is applied label Oct 31, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Oct 31, 2025
Copy link
Contributor

@JamieB-gu JamieB-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Couple of small comments.

@oliverabrahams oliverabrahams added the run_chromatic Runs chromatic when label is applied label Nov 3, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Nov 3, 2025
@oliverabrahams oliverabrahams added the run_chromatic Runs chromatic when label is applied label Nov 3, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Nov 3, 2025
@oliverabrahams oliverabrahams merged commit ec67385 into main Nov 3, 2025
31 checks passed
@oliverabrahams oliverabrahams deleted the mob/product-cards branch November 3, 2025 16:20
@gu-prout
Copy link

gu-prout bot commented Nov 3, 2025

Seen on PROD (merged by @oliverabrahams 8 minutes and 8 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants