Remove temporary body copy colour override on DCAR interactive articles #14361
+0
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days" |
|
This PR was closed because it has been stalled for 3 days with no activity. |
frederickobrien
force-pushed
the
remove-interactive-colour-override
branch
from
30ee5ab to
eeb249c
Compare
JamieB-gu
approved these changes
Oct 9, 2025
frederickobrien
force-pushed
the
remove-interactive-colour-override
branch
from
eeb249c to
db7713b
Compare
Reettaphant
added
maintenance
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the dust has settled on the DCAR migration of interactive articles, this follows up on #14049 and #14074 by rolling back enforced body copy colour responsiveness.
See the original PRs for more context but essentially a hardcoded colour value in the interactive templates was keeping body copy black regardless of whether the page was in dark mode or not. This overrode that as a temporary measure - the long term fix being to tidy up the old interactives then roll back the override.