Rework flexible/general stories
#12464
Open
+295
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2 B (0%) Total Size: 923 kB ℹ️ View Unchanged
|
cemms1
force-pushed
the
cemms1/flexible-general-stories
branch
from
de127b7
to
e4592ad
Compare
cemms1
commented
Sep 27, 2024
| @@ -154,7 +154,7 @@ const HorizontalDivider = () => ( | |||
| ${from.desktop} { | |||
| width: 140px; | |||
| } | |||
| margin-top: 12px; | |||
| margin-top: ${space[3]}px; | |||
There was a problem hiding this comment.
not related, just ensuring we use source spacing where possible
cemms1
commented
Sep 27, 2024
| @@ -101,8 +101,8 @@ export const OneCardLayout = ({ | |||
| imagePositionOnMobile, | |||
| supportingContentAlignment, | |||
| } = determineCardProperties( | |||
| card.boostLevel, | |||
| card?.supportingContent?.length ?? 0, | |||
| card.boostLevel ?? 'default', | |||
There was a problem hiding this comment.
Refactoring: cards with unspecified boostLevel are considered to be unboosted ie "default"
cemms1
commented
Sep 27, 2024
| @@ -19,7 +19,7 @@ type Props = { | |||
| absoluteServerTimes: boolean; | |||
| }; | |||
|
|
|||
| type boostProperties = { | |||
| type BoostProperties = { | |||
There was a problem hiding this comment.
Types should be PascalCase rather than camelCase. This is flagged up in eslint:
github-actions
bot
removed
the
run_chromatic
cemms1
force-pushed
the
cemms1/flexible-general-stories
branch
from
192d04a
to
73c16f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Updates the Storybook stories for the
FlexibleGeneralcomponent to better demonstrate the variations in designs for various card configurations in as few stories as possible.We now create a list of standard cards with defined variations in design so that we can visualise all the design quirks in one story. Each story now represents variations to the splash (sublinks + boost level) and not variations in the standard cards
Also contains other semi-related refactoring work to
FlexibleSpecialandFlexibleGeneralWhy?
Part of this Trello ticket
We can use this to better visualise and document which design variations and configuration options there are with the
FlexibleGeneralcontainer as well as showing what design features are currently missing.See Chromatic diff for better visualisation of changes.
Screenshots