-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use local copy of article format types #12461
Draft
jamesmockett
wants to merge
7
commits into
main
Choose a base branch
from
jm/move-article-format-dcar
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmockett
changed the title
Move article formats across from
Use local copy of article format types
Sep 26, 2024
@guardian/libs
Size Change: -23 kB (-2.45%) Total Size: 917 kB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
@guardian/libs
:ArticleDesign
ArticleDisplay
ArticleSpecial
ArticleTheme
ArticleFormat
Pillar
Why?
A small number of Source Development Kitchen components expose a
format
prop which is typed asArticleFormat
. Due to the need for these types to be used by Source and DCR they currently live in@guardian/libs
, although DCR is the main consumer. We want to decouple this dependency by refactoring the Source components to replace theformat
prop with a more generic theming mechanism, not tied to article formats, and move the types from@guardian/libs
to the DCR codebase where they can be more easily updated.This is part of a larger piece of work to remove
PrintShop
fromArticleDesign
.