Ticker Update #12153
Open
Ticker Update #12153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trying to get this to run like an animation
Storybook displaying new ticker
adjusted the padding and some other styles
|
Size Change: -1.18 kB (-0.12%) Total Size: 952 kB
ℹ️ View Unchanged
|
tomrf1
reviewed
Sep 5, 2024
| @@ -264,12 +264,15 @@ const DesignableBanner: ReactComponent<BannerRenderProps> = ({ | |||
| imageSettings, | |||
| bannerId: 'designable-banner', | |||
| tickerStylingSettings: { | |||
| textColour: hexColourToString(ticker.text), | |||
| //text: hexColourToString(ticker.text), | |||
There was a problem hiding this comment.
nice catch - complete oversight by me!!
tomrf1
reviewed
Sep 5, 2024
| totalColour: '#5056F5', | ||
| goalColour: '#000000', | ||
| //text: '#000000', // Deprecated, still needs a value | ||
| //goalMarker: '#000000', // Deprecated, still needs a value |
There was a problem hiding this comment.
nice catch - complete oversight by me!!
tomrf1
reviewed
Sep 5, 2024
| @@ -1,12 +1,7 @@ | |||
| /** | |||
There was a problem hiding this comment.
yes good spot it's not being used anymore
tomrf1
reviewed
Sep 6, 2024
| @@ -105,7 +105,7 @@ const MetaGridByline = ({ | |||
| padding-bottom: 0px; | |||
| } | |||
| address > div > span > svg:first-of-type { | |||
| address > div > span > div:first-of-type { | |||
There was a problem hiding this comment.
I don't think this change is related to the ticker is it?
There was a problem hiding this comment.
oh sorry, just noticed @domlander pushed this as a fix
There was a problem hiding this comment.
This change isn't related to the ticker, but is required for the update to source-development-kitchen. I thought we could get this PR out with this small fix, but it turns out we can't update this without also updating source at the same time, which will take a bit more effort.
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Update the banner and Epic ticker to align with the most recent design in Source. Figma deisgn
Please note that the Epic ticker colours are currently hard-coded and not configurable in the RRCP. However, the banner ticker colours can be customised via the RRCP, as this is the existing behaviour.
This has been tested end to end on CODE by creating a new banner design and epic test and ensuring that both tests render on a DCR article.
Screenshots
New ticker:
On Epic:
On banner:
