Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Source v8 #12151

Closed
jamesmockett opened this issue Aug 15, 2024 · 4 comments · Fixed by #12474
Closed

Update to Source v8 #12151

jamesmockett opened this issue Aug 15, 2024 · 4 comments · Fixed by #12474
Assignees
@jamesmockett
Labels
Dependencies Pull requests that update a dependency file
Milestone
Health

Comments

@jamesmockett
Copy link
Contributor

jamesmockett commented Aug 15, 2024 •
edited
Loading

Charlotte has an open PR (#12063) to bump Source from 1.0.3 to 6.1.0 as this includes new typography presets that are required for work on Fairground. There are a number of breaking changes due to the leap in versions which this PR addresses.

Alex has opened a follow-on PR to bump Source to 7.0.0 (#12145) which has been subsequently released. This removes the deprecated typography API which is still referenced in a handful of places in the codebase. These need to be updated in order to update to the latest version of Source and any future versions.

DCR

Errors  Files
     1  src/components/ArticleBody.tsx:6
     1  src/components/ContainerTitle.tsx:5
     1  src/components/DropCap.tsx:3
     1  src/components/ExpandableAtom/Summary.tsx:3
     1  src/components/HighlightBlockComponent.tsx:2
     1  src/components/LatestLinks.importable.tsx:3
     1  src/components/ManyNewslettersForm.tsx:4
     1  src/components/ManyNewsletterSignUp.importable.tsx:4
     2  src/components/NewsletterCard.tsx:3
     2  src/components/RichLink.tsx:4
     1  src/components/SignInGate/gateDesigns/SignInGateMainCheckoutComplete.tsx:5
     1  src/components/TimelineAtom.importable.tsx:3
     1  src/components/YoutubeBlockComponent.importable.tsx:3

AR

Errors  Files
     5  src/components/editions/byline/index.tsx:7
     3  src/components/editions/headline/index.tsx:7
     4  src/components/editions/standfirst/index.tsx:7
     1  src/components/SpecialReportAltAtom/index.tsx:5
@jamesmockett jamesmockett converted this from a draft issue Aug 15, 2024
@jamesmockett jamesmockett added this to the Health milestone Aug 15, 2024
@jamesmockett jamesmockett self-assigned this Aug 15, 2024
@jamesmockett jamesmockett added the Dependencies Pull requests that update a dependency file label Aug 15, 2024
@jamesmockett
Copy link
Contributor Author

Moving to blocked as #12063 needs updating first. I'm talking to Charlotte to co-ordinate.

@jamesmockett
Copy link
Contributor Author

jamesmockett commented Aug 29, 2024 •
edited
Loading

On further investigation we've discovered that Source v4 introduced a regression that prevents styles overrides added with the css prop from being applied. This has broken dark mode theming in a handful of places.

Source officially supports overrides via the cssOverrides and theme props, but never officially supported the css prop which is added by Emotion. Nonetheless, it's used in a number of places in the codebase.

I've spoken to the end to end team who are looking into why the behaviour as changed, but as this was never supported it seems like the best way forward is to replace any use of css on Source components with cssOverrides. The difficulty is in finding all instances given the size of the codebase. Many are covered by Chromatic, but there may be instances that are not and get overlooked.

@domlander domlander mentioned this issue Sep 6, 2024
Merged
@cemms1
Copy link
Contributor

cemms1 commented Sep 10, 2024

This should be unblocked now that #12218 has been merged

@jamesmockett jamesmockett changed the title Update to Source v7 Update to Source v8 Sep 11, 2024
@jamesmockett
Copy link
Contributor Author

Moving back into blocked for the moment as this requires an update to braze-components which has Source as a peer dependency and has to be updated to account for the breaking changes introduced in v7 and 8.

@jamesmockett jamesmockett linked a pull request Sep 30, 2024 that will close this issue
Update Source to 8.0.0 #12474
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in WebX Team Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesmockett jamesmockett

Labels
Dependencies Pull requests that update a dependency file
Projects
WebX Team
Archived in project
Milestone
Health
Development

Successfully merging a pull request may close this issue.

Update Source to 8.0.0 guardian/dotcom-rendering
2 participants
@jamesmockett @cemms1