Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require review from DevX before merging #50

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Conversation

NovemberTang
Copy link
Contributor

What does this change?

Sets DevX up as codeowners for the repo.

Have we considered potential risks?

Other teams may want to be able to make their own changes to particular actions. In this instance, they can modify the codeowners file to take ownership of particular parts of the repository

@NovemberTang NovemberTang enabled auto-merge March 8, 2023 11:11
Copy link
Contributor

@kenoir kenoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@NovemberTang NovemberTang merged commit fec495e into main Mar 8, 2023
@NovemberTang NovemberTang deleted the nt/codeowners branch March 8, 2023 11:12
@akash1810
Copy link
Member

akash1810 commented Mar 8, 2023

I don't think DevX should be owners of the entire repository. #7, for example. is a departmental concern. Should we scope ownership to the .workflows directory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants