refactor(HasSudoPassword): improve escaping of sudo password

- Return sudo password as a string - Use EscapeArg::escape() to escape sudo password
guanguans · Jul 14, 2023 · aa10e5c · aa10e5c
1 parent 7bab1d4
commit aa10e5c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Concerns/HasSudoPassword.php b/src/Concerns/HasSudoPassword.php
@@ -39,7 +39,7 @@ public function setSudoPassword(?string $sudoPassword): self
 
     protected function getEscapedSudoPassword(): string
     {
-        return EscapeArg::escape($this->sudoPassword);
+        return EscapeArg::escape((string) $this->sudoPassword);
     }
 
     protected function shouldApplySudoPassword(): bool

diff --git a/tests/Concerns/WithRunableTest.php b/tests/Concerns/WithRunableTest.php
@@ -54,13 +54,13 @@ protected function shouldApplySudoPassword(): bool
             }
         };
         $fatalErrorMessages = [
-            'sudo',
-            'password',
+            // 'sudo',
+            // 'password',
         ];
 
         $this->expectException(ProcessFailedException::class);
         foreach ($fatalErrorMessages as $fatalErrorMessage) {
-            // $this->expectExceptionMessage($fatalErrorMessage);
+            $this->expectExceptionMessage($fatalErrorMessage);
         }
 
         $soar->setSudoPassword('foo')->setQuery('select bar;')->run();