perf(app): optimize download performance

- Move the download logic inside a timebox to limit execution time - Use a progress callback to track the download progress - Display progress information during the download - Finish the progress when the download is complete
guanguans · Oct 17, 2024 · 9630046 · 9630046
1 parent eb9ffc6
commit 9630046
Showing 1 changed file with 25 additions and 20 deletions.
diff --git a/app/Music.php b/app/Music.php
@@ -26,6 +26,7 @@
 use Illuminate\Support\Traits\Macroable;
 use Illuminate\Support\Traits\Tappable;
 use Laravel\Prompts\Progress;
+use Psr\Http\Message\ResponseInterface;
 use function Laravel\Prompts\progress;
 
 final class Music implements Contracts\HttpClientFactory, Contracts\Music
@@ -80,30 +81,34 @@ public function search(string $keyword, array $sources = []): Collection
     /**
      * @psalm-suppress UnusedVariable
      *
+     * @throws \Throwable
      * @throws GuzzleException
      */
     public function download(string $url, string $savedPath): void
     {
-        $this->createHttpClient()->get($url, [
-            'sink' => $savedPath,
-            'progress' => static function (int $totalDownload, int $downloaded) use (&$progress, $savedPath): void {
-                if (0 === $totalDownload || 0 === $downloaded || 'submit' === $progress?->state) {
-                    return;
-                }
-
-                if (!$progress instanceof Progress) {
-                    /** @noinspection PhpVoidFunctionResultUsedInspection */
-                    $progress = tap(progress($savedPath, $totalDownload))->start();
-                }
-
-                if ($totalDownload === $downloaded) {
-                    $progress->finish();
-                }
-
-                $progress->progress = $downloaded;
-                $progress->render();
-            },
-        ]);
+        $this->timebox->call(
+            fn (): ResponseInterface => $this->createHttpClient()->get($url, [
+                'sink' => $savedPath,
+                'progress' => static function (int $totalDownload, int $downloaded) use (&$progress, $savedPath): void {
+                    if (0 === $totalDownload || 0 === $downloaded || 'submit' === $progress?->state) {
+                        return;
+                    }
+
+                    if (!$progress instanceof Progress) {
+                        /** @noinspection PhpVoidFunctionResultUsedInspection */
+                        $progress = tap(progress($savedPath, $totalDownload))->start();
+                    }
+
+                    if ($totalDownload === $downloaded) {
+                        $progress->finish();
+                    }
+
+                    $progress->progress = $downloaded;
+                    $progress->render();
+                },
+            ]),
+            $this->minCallMicroseconds
+        );
     }
 
     public function setMeting(Meting $meting): self