-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dis plugin changes #405
base: master
Are you sure you want to change the base?
Dis plugin changes #405
Conversation
Add a request_id field to the GenerateEntity and EntityGenerated messages. When Scrimmage generates an entity at runtime, it will copy the request ID from the GenerateEntity message to the EntityGenerated message. This is to allow plugins that generate entities to be able to associate a GenerateEntity request with the entity that was generated in response
@tm132 is this still relevant? |
Most likely, yes. This PR is from a notional (proof of concept) DIS implementation from an IRAD last year. |
We'll wait and see what arrives and keep the PR open! |
@tm132 Any movement on this PR? |
Nothing yet. In general, this adds parameter that allows the caller to send a token to the entity generation code, which then associates that token with whatever entity it generates so that whoever called it knows what id the entity they requested to be created got assigned. I think this is generally useful beyond the DIS plugin, and might not be a bad idea to merge anyway. I'd say, if it can be merged without causing problems, go ahead. If there's any cleanup you'd like me to do prior to a merge, just let me know what you'd like done and I can do it. |
@tm132 This branch has conflicts, can you rebase off of master? |
I have rebased this branch off master. |
These are the changes made to enable creation of entities on the fly for the purposes of implementing DIS Sender and DIS Receiver plugins in SCRIMMAGE. These changes are to add a request token during entity creation on the fly.
(Also, one of the plugins wasn't building due to library ref so that was changed in this branch as well eigen3/Eigen -> Eigen)