Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dis plugin changes #405

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Dis plugin changes #405

wants to merge 2 commits into from

Conversation

tm132
Copy link
Contributor

@tm132 tm132 commented Jan 21, 2020

These are the changes made to enable creation of entities on the fly for the purposes of implementing DIS Sender and DIS Receiver plugins in SCRIMMAGE. These changes are to add a request token during entity creation on the fly.

(Also, one of the plugins wasn't building due to library ref so that was changed in this branch as well eigen3/Eigen -> Eigen)

Add a request_id field to the GenerateEntity and EntityGenerated
messages. When Scrimmage generates an entity at runtime, it will copy
the request ID from the GenerateEntity message to the EntityGenerated
message. This is to allow plugins that generate entities to be able to
associate a GenerateEntity request with the entity that was generated
in response
@mday299
Copy link

mday299 commented Dec 10, 2020

@tm132 is this still relevant?

@tm132
Copy link
Contributor Author

tm132 commented Dec 11, 2020

Most likely, yes. This PR is from a notional (proof of concept) DIS implementation from an IRAD last year.
For now, I can either delete the PR if you're trying to clean up outstanding PRs, or the PR should wait on additional changes for when the DIS implementation becomes more formalized. It's up to you.

@mday299
Copy link

mday299 commented Dec 17, 2020

We'll wait and see what arrives and keep the PR open!

@mday299
Copy link

mday299 commented Mar 25, 2021

@tm132 Any movement on this PR?

@tm132
Copy link
Contributor Author

tm132 commented Mar 25, 2021

Nothing yet.

In general, this adds parameter that allows the caller to send a token to the entity generation code, which then associates that token with whatever entity it generates so that whoever called it knows what id the entity they requested to be created got assigned. I think this is generally useful beyond the DIS plugin, and might not be a bad idea to merge anyway.

I'd say, if it can be merged without causing problems, go ahead. If there's any cleanup you'd like me to do prior to a merge, just let me know what you'd like done and I can do it.

@mday299
Copy link

mday299 commented Mar 25, 2021

@tm132 This branch has conflicts, can you rebase off of master?

@tm132
Copy link
Contributor Author

tm132 commented Mar 26, 2021

I have rebased this branch off master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants