Fix bit shift overflow when reading cartridge size from header #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`left shift count >= width of type` With optimization on, `cartridge_size` will result in garbage/undefined behavior and break loading of games not found in the database, because the size will always be > 131072 and wrongly identify `cartridge_type` as `CARTRIDGE_TYPE_SUPERCART_LARGE`
|
Seems like this is dead, but I merged #1 and #2 into https://github.com/Provenance-Emu/ProSystem1_3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
left shift count >= width of typeWith optimization on,
cartridge_sizewill result in garbage/undefined behavior and break loading of games not found in the database, because the size will always be > 131072 and wrongly identifycartridge_typeasCARTRIDGE_TYPE_SUPERCART_LARGE