Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch parent folder on file modification #2422

Closed
wants to merge 1 commit into from

Conversation

elyahw
Copy link
Contributor

@elyahw elyahw commented Sep 21, 2024

This solves #2382

@harshad1
Copy link
Collaborator

I still oppose including this in mainline markor (we will have to check the effect on every sync solution etc as this is nonstandard behavior for a file manager)

That said, if the author would like to merge this into their personal branch, I would make the following changes:

  1. Touch the parent folder in the Document class
  2. Don't use currentTimeMillis(), instead copy the stamp from the just written file

@gsantner
Copy link
Owner

I can also suggest to guard it with try catch.

This change is at pretty much the most dangerous point of the project. You don't want to lose any file contents, just because your filesystem throws some error by touching.

@gsantner gsantner marked this pull request as draft September 24, 2024 22:21
@elyahw elyahw closed this by deleting the head repository Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants