-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for HeadlineDialog scroll restoration and copy code block button #2406
Merged
gsantner
merged 10 commits into
gsantner:master
from
guanglinn:headline_dialog_improvements
Sep 24, 2024
Merged
Improvements for HeadlineDialog scroll restoration and copy code block button #2406
gsantner
merged 10 commits into
gsantner:master
from
guanglinn:headline_dialog_improvements
Sep 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guanglinn
changed the title
HeadlineDialog scroll restoration and other improvements
Improve HeadlineDialog scroll restoration and other improvements
Sep 4, 2024
guanglinn
changed the title
Improve HeadlineDialog scroll restoration and other improvements
Improve HeadlineDialog scroll restoration and other issues
Sep 4, 2024
harshad1
reviewed
Sep 4, 2024
app/src/main/java/net/gsantner/markor/activity/DocumentEditAndViewFragment.java
Outdated
Show resolved
Hide resolved
guanglinn
changed the title
Improve HeadlineDialog scroll restoration and other issues
Improve HeadlineDialog scroll restoration and other improvements
Sep 7, 2024
guanglinn
changed the title
Improve HeadlineDialog scroll restoration and other improvements
Improvements for HeadlineDialog scroll restoration and copy to clipboard button
Sep 12, 2024
guanglinn
changed the title
Improvements for HeadlineDialog scroll restoration and copy to clipboard button
Improvements for HeadlineDialog scroll restoration and copy code block button
Sep 12, 2024
has conflicts |
Conflicts are resolved :) |
gsantner
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements for HeadlineDialog scroll restoration, line numbers in code blocks, copying code block button and other improvements.