Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New file in file browser dialog #2120

Merged
merged 11 commits into from
Nov 14, 2023

Conversation

harshad1
Copy link
Collaborator

@harshad1 harshad1 commented Oct 9, 2023

When sharing something into markor, it makes sense for the new file dialog and existing file dialogs to be combined.

This way you can select an existing file if it is already present or create a new one if it isn't.

I have also reduced the icon size and made them transparent so that they don't block information.

TBD

  • Should we immediately append to new file once created or show the new file in the browser to be selected
  • Should we show the editor after appending
  • Adjust icon size, position and transparency for best result

@harshad1
Copy link
Collaborator Author

harshad1 commented Oct 9, 2023

Screenshot_20231009-120112|200

How it currently looks

@harshad1 harshad1 changed the title WIP: New file in file browser dialog New file in file browser dialog Oct 10, 2023
@harshad1
Copy link
Collaborator Author

harshad1 commented Nov 1, 2023

Forgot to add this earlier. The dialog is now simplified - no more extra button

image|200

Copy link
Owner

@gsantner gsantner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@gsantner gsantner merged commit 6ffe87d into gsantner:master Nov 14, 2023
1 check passed
@harshad1 harshad1 deleted the newfile_in_browser_dialog branch August 18, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants