Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some incomplete and general things #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DJCordhose
Copy link

  • why router when you only have one route?
  • why you no typescript or no flow?
  • redux installed but not used, instead I see setState quite a lot
  • service is not common in react, but this looks like a valid use case for it

@gsans
Copy link
Owner

gsans commented Apr 25, 2017

Thanks for taking the time Oliver.

  • there will be routes! 😊
  • no idea how to integrate TS or flow but seems legit
  • yeah need to migrate those to Redux. No biggy
  • I see Services!

@DJCordhose
Copy link
Author

Cool, I can help with either TypeScript or Flow. All you need to do is to decide which one you like better:

TL'DR: TypeScript has the better tooling and seems more mature, but Flow still lives in the Babel world and is easier to integrate into an existing project. It also has the more powerful type system.

@DJCordhose
Copy link
Author

Also you can generate propTypes from Flow types using a babel plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants