Skip to content
This repository has been archived by the owner on Dec 16, 2020. It is now read-only.

Add test for checking create_resources does not actually create any resources #43

Merged
merged 5 commits into from
Oct 21, 2019
Merged

Add test for checking create_resources does not actually create any resources #43

merged 5 commits into from
Oct 21, 2019

Conversation

yorinasub17
Copy link
Contributor

@yorinasub17 yorinasub17 commented Oct 18, 2019 •
edited
Loading

Fixes #42

This PR adds a regression test to verify the behavior of the create_resources input variable.

NOTE: In order to make sure it works, I had to also insert the behavior of create_resources to k8s-service-account so that is an additional feature being included here.

@yorinasub17 yorinasub17 mentioned this pull request Oct 18, 2019
Closed
robmorgan
robmorgan approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@robmorgan robmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yorinasub17
Copy link
Contributor Author

Thanks for the review. Merging and releasing this!

@yorinasub17 yorinasub17 merged commit 720588a into master Oct 21, 2019
@yorinasub17 yorinasub17 deleted the yori-address-create-resources branch October 21, 2019 18:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robmorgan robmorgan robmorgan approved these changes

@autero1 autero1 Awaiting requested review from autero1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fails with error if create_resources set to false
2 participants
@yorinasub17 @robmorgan