Skip to content
This repository has been archived by the owner on Dec 16, 2020. It is now read-only.

Add option tiller_listen_localhost to to disable listen localhost #41

Merged
merged 6 commits into from
Oct 9, 2019

Conversation

bhegazy
Copy link
Contributor

@bhegazy bhegazy commented Oct 2, 2019

Hi,

My case is using flux-helm-operator integration with Tiller TLS, if we set --listen=localhost:44134 flux wont be able to find tiller

Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! This makes sense to me. Can you run terraform fmt on the code?

@bhegazy
Copy link
Contributor Author

bhegazy commented Oct 2, 2019

Thanks, forgot about the fmt 👍

@yorinasub17
Copy link
Contributor

Ah can you do me a favor and bump https://github.com/gruntwork-io/terraform-kubernetes-helm/blob/master/.circleci/config.yml#L11 to 0.12.9 on this branch? Otherwise the fmt hook will fail in our CI because hashicorp/terraform#21434 wasn't fixed until 0.12.6 and I see the fmt you ran includes the heredoc fixes. Thanks!

@bhegazy
Copy link
Contributor Author

bhegazy commented Oct 3, 2019

Done 👍

@yorinasub17
Copy link
Contributor

Thanks! Just kicked off the build. Should be able to merge if that passes!

@yorinasub17
Copy link
Contributor

Ah once we bumped terraform, another unrelated file fmt changed because the bug is now fixed... Can you run terraform fmt on examples/k8s-tiller-kubergrunt-minikube/main.tf? That should be the last remaining fmt issue.

Thanks, and sorry for the back and forth.

@bhegazy
Copy link
Contributor Author

bhegazy commented Oct 8, 2019

Sure will edit it tonight and push

@bhegazy
Copy link
Contributor Author

bhegazy commented Oct 9, 2019

Done @yorinasub17 let me know if there is any changes needed

@yorinasub17
Copy link
Contributor

Merging this in. Thanks for the contribution!

@yorinasub17 yorinasub17 merged commit 1bd61be into gruntwork-io:master Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants