Skip to content
This repository has been archived by the owner on Dec 16, 2020. It is now read-only.

Simplify TLS args #23

Merged
merged 5 commits into from
Apr 15, 2019
Merged

Simplify TLS args #23

merged 5 commits into from
Apr 15, 2019

Conversation

yorinasub17
Copy link
Contributor

Depends on gruntwork-io/kubergrunt#40

This simplifies the TLS arg computations by leveraging the subject-json flags, which allow encoding of the TLS flags in JSON format which works well with the map input. I also moved the arg computation to main.tf because I realized it makes a lot more sense there than dependencies.tf

robmorgan
robmorgan approved these changes Apr 12, 2019
View reviewed changes
Copy link
Contributor

@robmorgan robmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yorinasub17
Copy link
Contributor Author

Merging and releasing

@yorinasub17 yorinasub17 merged commit 91fc779 into master Apr 15, 2019
@yorinasub17 yorinasub17 deleted the yori-simplified-tls-args branch April 15, 2019 16:52
@yorinasub17
Copy link
Contributor Author

Thanks for the review!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robmorgan robmorgan robmorgan approved these changes

@autero1 autero1 Awaiting requested review from autero1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yorinasub17 @robmorgan