Skip to content
This repository has been archived by the owner on Mar 29, 2023. It is now read-only.

Commit

Permalink
Merge pull request #77 from craigedmunds/fix/71-removal-of-k8s-dashboard
Browse files Browse the repository at this point in the history
Removes the kubernetes_dashboard element from google_container_cluste…
  • Loading branch information
autero1 authored Jan 6, 2020
2 parents a32244a + 4e279e6 commit 8fcecd8
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 14 deletions.
8 changes: 0 additions & 8 deletions modules/gke-cluster/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,6 @@ resource "google_container_cluster" "cluster" {
disabled = ! var.horizontal_pod_autoscaling
}

kubernetes_dashboard {
disabled = ! var.enable_kubernetes_dashboard
}

network_policy_config {
disabled = ! var.enable_network_policy
}
Expand All @@ -100,10 +96,6 @@ resource "google_container_cluster" "cluster" {
master_auth {
username = var.basic_auth_username
password = var.basic_auth_password

client_certificate_config {
issue_client_certificate = var.enable_kubernetes_dashboard
}
}

dynamic "master_authorized_networks_config" {
Expand Down
6 changes: 0 additions & 6 deletions modules/gke-cluster/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -155,12 +155,6 @@ variable "alternative_default_service_account" {
# These values shouldn't be changed; they're following the best practices defined at https://cloud.google.com/kubernetes-engine/docs/how-to/hardening-your-cluster
# ---------------------------------------------------------------------------------------------------------------------

variable "enable_kubernetes_dashboard" {
description = "Whether to enable the Kubernetes Web UI (Dashboard). The Web UI requires a highly privileged security account."
type = bool
default = false
}

variable "enable_legacy_abac" {
description = "Whether to enable legacy Attribute-Based Access Control (ABAC). RBAC has significant security advantages over ABAC."
type = bool
Expand Down

0 comments on commit 8fcecd8

Please sign in to comment.