Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FMT-75 Add hook for packer fmt #76

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

godotgildor
Copy link

@godotgildor godotgildor commented May 18, 2022

Description

Creates a hook for running packer fmt similar to the hook for running terraform fmt.

resolves #75

Documentation

Updated README.md to describe the new hook.

TODOs

Please ensure all of these TODOs are completed before asking for a review.

  • [ X] Ensure the branch is named correctly with the issue number. e.g: feature/new-vpc-endpoints-955 or bug/missing-count-param-434.
  • [ X] Update the docs.
  • [X ] Keep the changes backward compatible where possible.
  • [ ?] Run the pre-commit checks successfully.
  • [X ] Run the relevant tests successfully.
  • [ X] Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.

Related Issues

NA

@godotgildor
Copy link
Author

Any questions, suggestions, or concerns @brikis98 or @yorinasub17 ?

@godotgildor godotgildor changed the title * Add hook for packer fmt FMT-75 Add hook for packer fmt Jun 3, 2022
@godotgildor
Copy link
Author

@brikis98 or @yorinasub17 - any update on this PR?

@godotgildor
Copy link
Author

@brikis98 or @yorinasub17 - any chance to get a quick review on this? I think having a packer fmt hook would be a nice addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add packer fmt hook
1 participant