Fix interrupt for Windows #402
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this still an issue in Node 0.12? If so, can you open a ticket on https://github.com/joyent/node/issues?q=is:open ? |
|
Currently, master fails for unix too. I've asked @vladikoff to add AppVeyor for this repo so we can test Windows too later. But I do recall getting failures in fstat.mode tests. |
|
This is not going to land until there's a Node.js ticket for it, so there's a chance it will be fixed eventually. Also make sure it's not fixed in Node.js 4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interrupt feature and unit tests were failing on Windows with Node v0.10.35 and Grunt v0.4.5. It looks like the exit code on interrupt is null, which is causing the task to be prematurely terminated. The result is that subsequent interrupt tasks fail.
This did not appear to be an issue on OSX with the same versions of Node/Grunt installed.